Skip to content

feat(DIA-1108): InfiniteDisco prefetch artist data #11656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(DIA-1108): InfiniteDisco prefetch artist data #11656

wants to merge 1 commit into from

Conversation

araujobarret
Copy link
Contributor

@araujobarret araujobarret commented Mar 12, 2025 •
edited
Loading

This PR resolves DIA-1108

Description

Prefetches artist data when the topArtworkId changes.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • feat: infinite disco prefetch artist data when the top card changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@araujobarret araujobarret requested review from MounirDhahri, iskounen and a team March 12, 2025 09:09
@araujobarret araujobarret self-assigned this Mar 12, 2025
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (feat: infinite disco prefetch artist data when the top card changes - araujobarret)

Generated by 🚫 dangerJS against 8f4d62b

MounirDhahri
MounirDhahri approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks

@araujobarret
Copy link
Contributor Author

Putting this on-hold for now

@MounirDhahri
Copy link
Member

Let's merge this now that we have rolled out the first version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MounirDhahri MounirDhahri MounirDhahri approved these changes

@iskounen iskounen iskounen approved these changes

Assignees

@araujobarret araujobarret

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@araujobarret @ArtsyOpenSource @MounirDhahri @iskounen